refactor: comment naming rule of dom id #8
Conversation
f2c-ci-robot
bot
added
do-not-merge/work-in-progress
|
评论组件的前端部分也需要处理，否则会出现如下错误，导致只能显示一个输入框： |
修复 Emoji 选择组件无法正常初始化的问题。 原因是因为原来使用的 Emoji Mart 库可能会因为多次实例化导致异常，目前暂无解决方案，详情可查阅：missive/emoji-mart#812 目前改为使用 https://github.com/serebrov/emoji-mart-vue-test 代替。 Fixes #7 Ref #8 (comment) ```release-note 修复 Emoji 选择组件无法正常初始化的问题。 ```
|
@ruibaby: GitHub didn't allow me to request PR reviews from the following users: guqing. Note that only halo-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
# Conflicts: # src/main/java/run/halo/comment/widget/DefaultCommentWidget.java
guqing
changed the title
f2c-ci-robot
bot
removed
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
|
/lgtm |
What this PR does?
修改评论组件插入代码时的 dom id 命名规则，避免同一个页面有多个评论组件时出现 id 冲突导致无法显示的问题
参考： https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/id